[PATCH] D61754: [PowerPC] Custom lower known CR bit spills

Lei Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 10 12:47:39 PDT 2019


lei marked an inline comment as done.
lei added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:725
+  MachineBasicBlock::reverse_iterator Ins;
+  for (Ins=MI; Ins!=MBB.rend(); Ins++) {
+    if (Ins->modifiesRegister(SrcReg, TRI))
----------------
hfinkel wrote:
> I think that this makes sense, but I'm a bit concerned that, without a cutoff, this makes the spilling process quadratic. Can you please add a cl::opt search cutoff for this?
How about `--ppc-max-crbit-spill-dist` with an initial value of 20?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61754/new/

https://reviews.llvm.org/D61754





More information about the llvm-commits mailing list