[PATCH] D61766: WIP: Speed-up leak and address sanitizers lsan prototype

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_allocator_primary_pair.h:12
+//===----------------------------------------------------------------------===//
+#ifndef SANITIZER_ALLOCATOR_H
+#error This file must be included inside sanitizer_allocator.h
----------------
Not sure that we need #ifndef SANITIZER_ALLOCATOR_H here

still regular protection would be nice:

#ifndef SANITIZER_ALLOCATOR_PRIMARY_PAIR
#define SANITIZER_ALLOCATOR_PRIMARY_PAIR
...


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_allocator_primary_pair.h:16
+
+static bool use1 = false;
+
----------------
with "static bool" in the header each module will have one version of var.
let make it static member of the SizeClassAllocatorPair


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61766/new/

https://reviews.llvm.org/D61766