[PATCH] D61791: Replace lit feature keyword 'non_COFF' with 'uses_COFF'.

[Paul Robinson via Phabricator via llvm-commits]

probinson created this revision.
probinson added a reviewer: lhames.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Part of converting negative feature keywords to positive.
Giving Lang a chance to reject if he prefers 'non_COFF', the only uses are in the JIT tests.


Repository:
  rL LLVM

https://reviews.llvm.org/D61791

Files:
  llvm/test/ExecutionEngine/MCJIT/weak-function.ll
  llvm/test/ExecutionEngine/OrcMCJIT/weak-function.ll
  llvm/test/lit.cfg.py


Index: llvm/test/lit.cfg.py
===================================================================
--- llvm/test/lit.cfg.py
+++ llvm/test/lit.cfg.py
@@ -179,10 +179,12 @@
 
 config.available_features.add("host-byteorder-" + sys.byteorder + "-endian")
 
-# Others/can-execute.txt
-if sys.platform not in ['win32']:
+if sys.platform in ['win32']:
+    # ExecutionEngine, no weak symbols in COFF.
+    config.available_features.add('uses_COFF')
+else:
+    # Others/can-execute.txt
     config.available_features.add('can-execute')
-    config.available_features.add('not_COFF')
 
 # Loadable module
 # FIXME: This should be supplied by Makefile or autoconf.
Index: llvm/test/ExecutionEngine/OrcMCJIT/weak-function.ll
===================================================================
--- llvm/test/ExecutionEngine/OrcMCJIT/weak-function.ll
+++ llvm/test/ExecutionEngine/OrcMCJIT/weak-function.ll
@@ -1,5 +1,5 @@
 ; RUN: lli -jit-kind=orc-mcjit -extra-module %p/Inputs/weak-function-2.ll %s
-; REQUIRES: not_COFF
+; UNSUPPORTED: uses_COFF
 ;
 ; Check that functions in two different modules agree on the address of weak
 ; function 'baz'.
Index: llvm/test/ExecutionEngine/MCJIT/weak-function.ll
===================================================================
--- llvm/test/ExecutionEngine/MCJIT/weak-function.ll
+++ llvm/test/ExecutionEngine/MCJIT/weak-function.ll
@@ -1,5 +1,5 @@
 ; RUN: lli -jit-kind=mcjit -extra-module %p/Inputs/weak-function-2.ll %s
-; REQUIRES: not_COFF
+; UNSUPPORTED: uses_COFF
 ;
 ; Check that functions in two different modules agree on the address of weak
 ; function 'baz'


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61791.199025.patch
Type: text/x-patch
Size: 1601 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190510/7466992c/attachment.bin>