[PATCH] D61599: [Support] Reverted r357058 and r351916, MemoryBlock class now exposes its allocated size instead of requested size.

Fri May 10 05:24:33 PDT 2019

andrewng added a comment.

In D61599#1497031 <https://reviews.llvm.org/D61599#1497031>, @mvhooren wrote:

> Applied Clang Format to the changed files. Renamed bufferSize -> BufSize to match naming convention..

I think you may have applied clang-format to the whole file which has introduced quite a few formatting-only changes to your patch. The guidelines are to only clang-format the changed parts of the code, so that it is easier to see the "real" changes. See http://llvm.org/docs/GettingStarted.html#sending-patches for how to achieve this.

Otherwise, it looks fine to me, but probably best to get one of the other reviewers to give the OK too.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61599/new/

https://reviews.llvm.org/D61599