[PATCH] D61547: [IR] Disallow llvm.global_ctors and llvm.global_dtors of the 2-field form in textual format

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 9 11:54:23 PDT 2019


dexonsmith added a comment.

In D61547#1495855 <https://reviews.llvm.org/D61547#1495855>, @MaskRay wrote:

> In D61547#1495339 <https://reviews.llvm.org/D61547#1495339>, @rnk wrote:
>
> > Presumably `test/Bitcode/upgrade-global-ctors.ll.bc` should remain unchanged, i.e. not be regenerated? We want it to use the pre-upgraded, two field form.
>
>
> I used llvm-as without this patch to generate it. I added anither test to check the upgrader correctly adds i8* null


What's the problem with using the pre-existing file?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61547/new/

https://reviews.llvm.org/D61547





More information about the llvm-commits mailing list