[PATCH] D32530: [SVE][IR] Scalable Vector IR Type
Hal Finkel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 9 11:14:51 PDT 2019
hfinkel added a comment.
In D32530#1496960 <https://reviews.llvm.org/D32530#1496960>, @hsaito wrote:
> In D32530#1496945 <https://reviews.llvm.org/D32530#1496945>, @greened wrote:
>
> > What's the status of this? It seems like discussion has died down a bit. I think Graham's idea to change from `<scalable 2 x float>` to `<vscale x 2 x float>` will make the IR more readable/understandable but it's not a show-stopper for me.
> >
> > Are there any other outstanding issues to address before this lands?
>
>
> I think @huntergr still needs to update the insertelement/extractelement doc. For me, the last remaining thing is the definition of shufflevector behavior that his last revision did not address. Do we allow scalable vector? Do we allow anything other than zeroinitializer mask? I'm fine not allowing for the time being or restricting to zeroinitializer mask for the time being. We still need to write it down since generally supporting shufflevector of scalable vectors is outside the scope of this patch.
+1 - Once we have these documentation updates, I think that we'll be good to go.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D32530/new/
https://reviews.llvm.org/D32530
More information about the llvm-commits
mailing list