[PATCH] D61727: [llvm-objcopy] Add additional testing for various cases

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/common-suffix-string-tables.test:2
+## This test shows that when symbol/section names are optimized in the string
+## table to share the same entry, because one is a substring of the other,
+## llvm-objcopy operations function correctly without corrupting the names of
----------------
It is tail merge, not substring merge.


================
Comment at: test/tools/llvm-objcopy/ELF/common-suffix-string-tables.test:68
+Sections:
+  - Name: .blah.blag
+    Type: SHT_PROGBITS
----------------
Add another section to make tail merging clear? e.g. `.a.b.c` `.b.c` `.c`


================
Comment at: test/tools/llvm-objcopy/ELF/strip-sections.test:39
 #DATA: 0010000 de ad be ef ca fe ba be
+#DATA-NOT: fe ed fa ce
+
----------------
Nit: `#` -> `# `.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61727/new/

https://reviews.llvm.org/D61727