[PATCH] D61757: [cmake] Remove MSVC C4355 override

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 9 13:43:52 PDT 2019


RKSimon created this revision.
RKSimon added reviewers: gbedwell, zturner, andrew.w.kaylor, rnk.
Herald added a subscriber: mgorny.
Herald added a project: LLVM.

Remove C4355 : ''this' : used in base member initializer list' from the list of forced disabled warnings.

I'm not seeing any regressions in VS2017/VS2019 llvm/clang builds from removing this.


Repository:
  rL LLVM

https://reviews.llvm.org/D61757

Files:
  cmake/modules/HandleLLVMOptions.cmake


Index: cmake/modules/HandleLLVMOptions.cmake
===================================================================
--- cmake/modules/HandleLLVMOptions.cmake
+++ cmake/modules/HandleLLVMOptions.cmake
@@ -512,7 +512,6 @@
       -wd4291 # Suppress ''declaration' : no matching operator delete found; memory will not be freed if initialization throws an exception'
       -wd4345 # Suppress 'behavior change: an object of POD type constructed with an initializer of the form () will be default-initialized'
       -wd4351 # Suppress 'new behavior: elements of array 'array' will be default initialized'
-      -wd4355 # Suppress ''this' : used in base member initializer list'
       -wd4456 # Suppress 'declaration of 'var' hides local variable'
       -wd4457 # Suppress 'declaration of 'var' hides function parameter'
       -wd4458 # Suppress 'declaration of 'var' hides class member'


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61757.198896.patch
Type: text/x-patch
Size: 890 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190509/a58be7ec/attachment.bin>


More information about the llvm-commits mailing list