[PATCH] D61741: Add comment about FSUB(-0.0,X) <--> FNEG(X) transforms
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 9 12:14:44 PDT 2019
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM - thanks!
================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:11632-11634
+ // NOTE: It is safe to xform an FSUB(-0.0,X) into an FNEG(X), since the
+ // FSUB does not specify the sign bit of a NaN. Also note that for
+ // the same reason, the inverse xform is not safe, unless fast math
----------------
Please spell out "transform" - "xform" may not be obvious even for native English readers.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61741/new/
https://reviews.llvm.org/D61741
More information about the llvm-commits
mailing list