[PATCH] D61660: [cmake] Make google benchmark project handle libraries properly when built in-tree

Don Hinton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 9 10:37:02 PDT 2019


hintonda added a comment.

In D61660#1496944 <https://reviews.llvm.org/D61660#1496944>, @beanz wrote:

> Using a macro seems reasonable if a bit icky.


Just thought I'd mention it.  Probably not necessary in this context since it shouldn't get called anywhere other than benchmark.  As a wrapper, scope if the only difference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61660/new/

https://reviews.llvm.org/D61660





More information about the llvm-commits mailing list