[PATCH] D61611: [JITLoaderGDB] Set eTypeJIT for objects read from JIT descriptors
    Pavel Labath via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu May  9 09:51:45 PDT 2019
    
    
  
labath added a comment.
In D61611#1496838 <https://reviews.llvm.org/D61611#1496838>, @probinson wrote:
> @stella.stamenova I'm not familiar with any lit feature that gives a special meaning to the prefix "no".  The opposite of "REQUIRES: windows" is not "REQUIRES: nowindows" but "UNSUPPORTED: windows" AFAIK.
>  This part of the discussion should probably be taken to llvm-dev, though.
There's a `binary_feature` function in `utils/lit/lit/llvm/config.py`, but it's only used in a handful of cases. And yeah, I would generally prefer `UNSUPPORTED: XYZ` over `REQUIRES: noXYZ`.
Repository:
  rL LLVM
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61611/new/
https://reviews.llvm.org/D61611
    
    
More information about the llvm-commits
mailing list