[PATCH] D61736: [MergeICmps] Simplify the code.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 9 08:39:56 PDT 2019


courbet created this revision.
courbet added a reviewer: gchatelet.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.
courbet retitled this revision from "[MergeICmps][NFC] Re-generate tests with update_test_checks." to "[MergeICmps][NFCI] Simplify the code.".
courbet edited the summary of this revision.
courbet retitled this revision from "[MergeICmps][NFCI] Simplify the code." to "[MergeICmps] Simplify the code.".

Instead of patching the original blocks, we now generate new blocks and
delete the old blocks. This results in simpler code with a less twisted
control flow (see the change in `entry-block-shuffled.ll`).

This will make https://reviews.llvm.org/D60318 simpler by making it more
obvious where control flow created and deleted.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D61736

Files:
  llvm/lib/Transforms/Scalar/MergeICmps.cpp
  llvm/test/Transforms/MergeICmps/X86/alias-merge-blocks.ll
  llvm/test/Transforms/MergeICmps/X86/atomic.ll
  llvm/test/Transforms/MergeICmps/X86/entry-block-shuffled.ll
  llvm/test/Transforms/MergeICmps/X86/gep-used-outside.ll
  llvm/test/Transforms/MergeICmps/X86/int64-and-ptr.ll
  llvm/test/Transforms/MergeICmps/X86/last-block-produce-no-value.ll
  llvm/test/Transforms/MergeICmps/X86/lit.local.cfg
  llvm/test/Transforms/MergeICmps/X86/multiple-blocks-does-work.ll
  llvm/test/Transforms/MergeICmps/X86/pair-int32-int32.ll
  llvm/test/Transforms/MergeICmps/X86/split-block-does-work.ll
  llvm/test/Transforms/MergeICmps/X86/two-complex-bb.ll
  llvm/test/Transforms/MergeICmps/X86/volatile.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61736.198839.patch
Type: text/x-patch
Size: 64313 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190509/b0fc17c3/attachment-0001.bin>


More information about the llvm-commits mailing list