[PATCH] D61308: [X86][SSE] Fold add(shuffle(),shuffle()) to hadd on 'slow' targets (PR39920)

Thu May 9 08:27:27 PDT 2019

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

In D61308#1496359 <https://reviews.llvm.org/D61308#1496359>, @RKSimon wrote:

> In D61308#1494883 <https://reviews.llvm.org/D61308#1494883>, @spatel wrote:
>
> > Is the PR22377 test the only remaining problem? If so, do we have a new bug to track that (or reopen the old bug)?
>
>
> Yes its just the PR22377 test case.
>
> I've raised https://bugs.llvm.org/show_bug.cgi?id=41813 but I'm not totally happy with it being so vague on what the best thing to do is.

Thanks. We're probably not going to regress the actual motivating example (AVX codegen) in PR22377 (although we could do better), so I think we're fine here. LGTM.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61308/new/

https://reviews.llvm.org/D61308