[PATCH] D58843: [WIP][MC][RISCV] Allow targets to defer forcing relocations

Lewis Revill via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 9 01:06:42 PDT 2019


lewis-revill added a comment.

In D58843#1486436 <https://reviews.llvm.org/D58843#1486436>, @rogfer01 wrote:

> Hi @lewis-revill,
>
> ...
>
> Hope these observations help!
>
> Kind regards,


Hi @rogfer01,

Thanks for your thoughts, sorry for the delay.

I was worried that this would be the issue with this patch, in terms of not working section-wise. I would imagine that even if we did manage to make it work section-wise then that would not make a good generic patch... Thanks for the analysis on this approach though, I didn't realise that that would happen.

I'd like to know some more detail about the actual use cases for this pre-linker evaluation of fixups, it's becoming increasingly clear that a lot of difficulties could be/could have been avoided by letting the RISC-V `shouldForceRelocation` just return true for `pcrel_hi`/`X_hi`/`pcrel_lo`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58843/new/

https://reviews.llvm.org/D58843





More information about the llvm-commits mailing list