[PATCH] D61727: [llvm-objcopy] Add additional testing for various cases

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 9 06:35:28 PDT 2019


MaskRay added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/common-suffix-string-tables.test:21
+# COPY: Sections [
+# COPY: Name: .blah.blag (
+# COPY: Name: .blag (
----------------
Indent the output as other tests do?


================
Comment at: test/tools/llvm-objcopy/ELF/invalid-e_phoff.test:15
+## Truncate the file to end before the program header table ends.
+# RUN: %python -c "with open('%/t.o', 'r+') as input: input.truncate(65)"
+# RUN: not llvm-objcopy %t.o 2>&1 | FileCheck %s
----------------
`'r+b'` if you want to make it work on Python 3 as well though.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61727/new/

https://reviews.llvm.org/D61727





More information about the llvm-commits mailing list