[PATCH] D61660: [cmake] Make google benchmark project handle libraries properly when built in-tree

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

I think i'm failing to convey the thoughts here.
Can you explain why you insist on having

  if(COMMAND llvm_add_library)
    function(benchmark_add_library target)
      llvm_add_library(${target} ${ARGN})
    endfunction()
  else()
    function(benchmark_add_library target)
      add_library(${target} ${ARGN})
    endfunction()
  endif()

in `llvm/utils/benchmark/CMakeLists.txt`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61660/new/

https://reviews.llvm.org/D61660