[PATCH] D52019: [AMDGPU] Divergence driven instruction selection. Part 1.

Samuel Pitoiset via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 9 02:53:10 PDT 2019


hakzsam added a comment.

In D52019#1496159 <https://reviews.llvm.org/D52019#1496159>, @arsenm wrote:

> In D52019#1496145 <https://reviews.llvm.org/D52019#1496145>, @hakzsam wrote:
>
> > Hi there,
> >
> > This change introduces a regression with RADV and Doom 2016, see https://bugs.freedesktop.org/show_bug.cgi?id=110636
> >  We just discovered this, so LLVM 8 and master are affected. :(
> >  I'm trying to find the root cause, I will let you know.
>
>
> Did r360293 fix it?


Yes, it did fix the problem.
Do you plan to backport to LLVM 8?

In D52019#1496159 <https://reviews.llvm.org/D52019#1496159>, @arsenm wrote:

> In D52019#1496145 <https://reviews.llvm.org/D52019#1496145>, @hakzsam wrote:
>
> > Hi there,
> >
> > This change introduces a regression with RADV and Doom 2016, see https://bugs.freedesktop.org/show_bug.cgi?id=110636
> >  We just discovered this, so LLVM 8 and master are affected. :(
> >  I'm trying to find the root cause, I will let you know.
>
>
> Did r360293 fix it?





CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52019/new/

https://reviews.llvm.org/D52019





More information about the llvm-commits mailing list