[PATCH] D61676: [MCA] Add support for nested and overlapping region markers

[Matt Davis via Phabricator via llvm-commits]

mattd added a comment.

This looks nice!  We should probably also have a test for the case where a user specifies an END before a BEGIN tag.



================
Comment at: docs/CommandGuide/llvm-mca.rst:241
+
+Note that nutliple anonymous regions cannot overlap. Also, overlapping regions
+cannot have the same name.
----------------
s/nutliple/multiple/


================
Comment at: tools/llvm-mca/CodeRegionGenerator.cpp:90
+    // Skip spaces and tabs.
+    Position = Comment.find_first_not_of(" \t");
+    if (Position < Comment.size())
----------------
Perhaps also include colon ':' as a valid delimiter here and in line 82 above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61676/new/

https://reviews.llvm.org/D61676