[PATCH] D61708: [TSan] Support `ignore_noninstrumented_modules` on Linux

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 8 17:47:25 PDT 2019


yln marked an inline comment as done.
yln added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cc:661
+      // TODO(yln): make this better
+      if (internal_strstr(name, "__tsan_"))
+        return true;
----------------
`ignore_noninstrumented_modules` is only relevant for TSan, but this code is in sanitizer_common. Is this acceptable? How can we make it better?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61708/new/

https://reviews.llvm.org/D61708





More information about the llvm-commits mailing list