[PATCH] D61699: [lld-link] initialize targets and asmparsers before invoking lib

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 8 14:20:18 PDT 2019


rnk added a comment.

Nice.



================
Comment at: lld/test/COFF/lib-module-asm.ll:4
+; RUN: llvm-as -o %t.obj %s
+; RUN: lld-link /lib /out:%t.lib %t.obj
+
----------------
Please extend this to put some symbols in the module assembly and then run llvm-nm on the archive to show that the archiver actually parsed the module level assembly and didn't just ignore it. There's a test at `llvm/test/Object/X86/archive-ir-asm.ll` that does this that you can steal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61699/new/

https://reviews.llvm.org/D61699





More information about the llvm-commits mailing list