[PATCH] D61445: [FileCheck] Fix code style of method comments
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 8 11:34:39 PDT 2019
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
One or two last nits and LGTM.
================
Comment at: llvm/include/llvm/Support/FileCheck.h:189
+ /// Defines pattern variables from definitions given on the command line,
+ /// passed as a vector of VAR=VAL strings in \p CmdlineDefines. Reports any
+ /// error to \p SM and \returns whether an error occured.
----------------
Depending on where this comes in the sequence of other patches, this might want to be "[#]VAR=VAL" (or not, if that syntax will be introduced after this patch, in which case ignore this comment).
================
Comment at: llvm/include/llvm/Support/FileCheck.h:439
- /// Read the check file, which specifies the sequence of expected strings.
+ /// Reads the check file from \p Buffer and record the expected strings it
+ /// contains in the \p CheckStrings vector. Errors are reported against
----------------
record -> records
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61445/new/
https://reviews.llvm.org/D61445
More information about the llvm-commits
mailing list