[PATCH] D61690: [X86] Deduplicate symbol lowering logic, NFC

[Reid Kleckner via Phabricator via llvm-commits]

rnk created this revision.
rnk added reviewers: craig.topper, RKSimon.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

This refactors four pieces of code that create SDNodes for references to
symbols:

- normal global address lowering (LEA, MOV, etc)
- callee global address lowering (CALL)
- external symbol address lowering (LEA, MOV, etc)
- external symbol address lowering (CALL)

Each of these pieces of code need to:

- classify the reference
- lower the symbol
- emit a RIP wrapper if needed
- emit a load if needed
- add offsets if needed

I think handling them all in one place will make the code easier to
maintain in the future.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D61690

Files:
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/lib/Target/X86/X86ISelLowering.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61690.198697.patch
Type: text/x-patch
Size: 9245 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190508/f9f20705/attachment.bin>