[PATCH] D60243: [LSan][AArch64] Speed-up leak and address sanitizers on AArch64 for 47-bit VMA

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

In D60243#1495410 <https://reviews.llvm.org/D60243#1495410>, @brzycki wrote:

> Hello @vitalybuka , thank you for the example in D61401 <https://reviews.llvm.org/D61401>. Do you have a suggestion what file and namespace the `DoubleAllocator` template class definition should reside? The most recent diff for D60243 <https://reviews.llvm.org/D60243> was authored April 3 and no longer cleanly applies (the file `lsan_allocator.h` has changed considerably since then). This is complicated by @sebpop changing jobs and requiring legal approval before he can help work on this again. In order to make progress I'm essentially re-writing this patch based on the new `Allocator` layout in `lsan_allocator.h`.


Probably namespace __sanitizer as you will need it for asan and lsan
have no idea about name. DoubleAllocator was for example but does not sound as helpful.
maybe DoubleAllocator -> SizeClassAllocatorPair in sanitizer_allocator_primary_pair.h.

Also instead of bool use1 maybe better to use virtual methods, but I suspect it will be more complicated. I am fine either way.
>From D60243 <https://reviews.llvm.org/D60243> probably you need only the part which decides which allocator to use and maybe make sure that we have appropriate AP32/AP64 for the new allocator


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60243/new/

https://reviews.llvm.org/D60243