[PATCH] D61660: [cmake] Make google benchmark project call llvm_add_library

[Don Hinton via Phabricator via llvm-commits]

hintonda added a comment.

In D61660#1495378 <https://reviews.llvm.org/D61660#1495378>, @beanz wrote:

> Could you change the title and commit message to reference that this isn't just about using `llvm_add_library` it is more broadly about making the benchmark library behave like a proper LLVM library target when built in-tree.
>
> @lebedev.ri, the extra changes here that you're objecting to are required. If Benchmark isn't built with the same CMake policies as the rest of LLVM you can't use `llvm_add_library` because it makes assumptions about the policy settings.


@beanz, should I also include the policies in the conditional?  I left them out, but wasn't sure that was the correct thing to do.  Based on you comment, they should only be set if not building within LLVM, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61660/new/

https://reviews.llvm.org/D61660