[PATCH] D61660: [cmake] Make google benchmark project call llvm_add_library

[Chris Bieneman via Phabricator via llvm-commits]

beanz added a comment.

Could you change the title and commit message to reference that this isn't just about using `llvm_add_library` it is more broadly about making the benchmark library behave like a proper LLVM library target when built in-tree.

@lebedev.ri, the extra changes here that you're objecting to are required. If Benchmark isn't built with the same CMake policies as the rest of LLVM you can't use `llvm_add_library` because it makes assumptions about the policy settings.



================
Comment at: llvm/utils/benchmark/CMakeLists.txt:6
+if( CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR )
+  project(Clang)
+  # Tell cmake 3.0+ that it's safe to clear the PROJECT_VERSION variable in the
----------------
Setting this to Clang seems wrong...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61660/new/

https://reviews.llvm.org/D61660