[PATCH] D59272: [DebugInfo] Select debug intrinsic line-numbers more carefully when promoting dbg.declare

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Transforms/Utils/Local.cpp:1290
+// only the scope and inlinedAt is significant. Zero line numbers are used in
+// case this DebugLoc leaks into any adjacent instructions.
+static DebugLoc getDebugValueLoc(DbgVariableIntrinsic *DII, Instruction *Src) {
----------------
///


================
Comment at: lib/Transforms/Utils/Local.cpp:1294
+  DebugLoc DeclareLoc = DII->getDebugLoc();
+  assert(DeclareLoc);
+  MDNode *Scope = DeclareLoc.getScope();
----------------
I think this is redundant with the access on the next line?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59272/new/

https://reviews.llvm.org/D59272