[PATCH] D61654: [scudo][standalone] Introduce the chunk header

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad updated this revision to Diff 198687.
cryptoad added a comment.
This revision is now accepted and ready to land.

I had to backpedal on some of changes due to some errors uncovered
while testing on Fuchsia.

The main reason is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61414
which complains that the number of bits used to store the `enum class`
is not enough (while it is, really). musl being compiled strictly on
Fuchsia, this ends up in an error. Keeping `State` and `Origin` as
`enum class`, except in the `UnpackedHeader` ended up requiring a
whole lot of `static_cast`.

In the end, to make it work on everything, I reverted back `Origin`
and `State` to standard `enum`, and added a comment explaining the
situation.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61654/new/

https://reviews.llvm.org/D61654

Files:
  lib/scudo/standalone/CMakeLists.txt
  lib/scudo/standalone/checksum.cc
  lib/scudo/standalone/checksum.h
  lib/scudo/standalone/chunk.h
  lib/scudo/standalone/tests/CMakeLists.txt
  lib/scudo/standalone/tests/chunk_test.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61654.198687.patch
Type: text/x-patch
Size: 11547 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190508/5e1ee9f7/attachment.bin>