[PATCH] D61679: [FileCheck, NFC] Split defines.txt in two

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D61679#1495260 <https://reviews.llvm.org/D61679#1495260>, @probinson wrote:

> Aha. The new versions add the word "pattern" to some of the diagnostics, in pattern-defines-diagnostics.txt.  That would be the functional change belonging to D60385 <https://reviews.llvm.org/D60385>, which means that test should not pass with an unmodified FileCheck? Please verify.
>
> I am sure this feels like I'm being very picky, but carefully dividing up functional and non-functional reviews makes the reviewer's life much simpler.


My bad, forgot that change. I've merged the two files manually to double check this time and it is now truly NFC and test still passes. Thanks for spotting that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61679/new/

https://reviews.llvm.org/D61679