[PATCH] D61647: llvm-objdump: when ELF st_other field is set, print its value before symbol name

Alfredo Dal'Ava JĂșnior via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 8 09:23:43 PDT 2019


adalava added a comment.

In D61647#1494441 <https://reviews.llvm.org/D61647#1494441>, @MaskRay wrote:

> This change makes sense and it will improve compatibility with GNU objdump. For your tests (I've commented there), I usually prefer llvm-readelf/llvm-readobj to llvm-objdump. The output of objdump also looks very weird to me. I remember @emaste said so in one FreeBSD issue.. I can check how many tests (you should at least check `ninja -C Release check-llvm check-lld`; clang has <5 llvm-objdump tests; ) will be impacted by this change. If there aren't many, I can fix them and commit that for you :)


MaskRay, looks like  many tests under lld/tests are using llvm-objdump, a grep for llvm-objdump on this folder returned  >1000 entries.
In any case I verified that llvm-readobj really can be used for my tests. I'll rewrite them for sure, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61647/new/

https://reviews.llvm.org/D61647





More information about the llvm-commits mailing list