[PATCH] D59436: [ELF] Fix missing ELF st_other field on versioned symbols

Alfredo Dal'Ava JĂșnior via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 8 09:13:12 PDT 2019


adalava added a comment.

In D59436#1494416 <https://reviews.llvm.org/D59436#1494416>, @MaskRay wrote:

> Thanks. The test contains some constructs that are not used, e.g. `.symver` `.addrsig`. And I think it is usually better to use llvm-readelf/llvm-readobj. I always find the output of llvm-objdump/objdump weird.. If you don't mind, I can rewrite/minimalize the test and commit for you.


Sure, please go ahead, thank you!
Just a reminder that test case in this patch depends on  D56586 <https://reviews.llvm.org/D56586> and D61647 <https://reviews.llvm.org/D61647>, so you may prefer to wait or move the test case to another revision


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59436/new/

https://reviews.llvm.org/D59436





More information about the llvm-commits mailing list