[PATCH] D61679: [FileCheck, NFC] Split defines.txt in two

Wed May 8 08:56:40 PDT 2019

probinson requested changes to this revision.
probinson added a comment.
This revision now requires changes to proceed.

Aha. The new versions add the word "pattern" to some of the diagnostics, in pattern-defines-diagnostics.txt.  That would be the functional change belonging to D60385 <https://reviews.llvm.org/D60385>, which means that test should not pass with an unmodified FileCheck? Please verify.

I am sure this feels like I'm being very picky, but carefully dividing up functional and non-functional reviews makes the reviewer's life much simpler.

================
Comment at: llvm/test/FileCheck/pattern-defines-diagnostics.txt:15
+
+; Missin variable name.
+RUN: not FileCheck -D=10 --input-file %s %s 2>&1 \
----------------
"Missing"

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61679/new/

https://reviews.llvm.org/D61679