[PATCH] D61654: [scudo][standalone] Introduce the chunk header

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad marked 2 inline comments as done.
cryptoad added inline comments.


================
Comment at: lib/scudo/standalone/tests/chunk_test.cc:23
+}
+
+TEST(ScudoChunkTest, ChunkBasic) {
----------------
vitalybuka wrote:
> you can wrap everything into
> namespace scudo::Chunk {
> or just add using scudo::Chunk;
> 
> 
While I agree that this would simplify a bit the code, I think not using `using` or putting the tests in the namespace allows for more clarity as to where class and functions are located within the hierarchy of the project. I actually like it better and it forced me to rethink a bit some of the code organization when I was writing the tests.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61654/new/

https://reviews.llvm.org/D61654