[PATCH] D61547: [IR] Disallow llvm.global_ctors and llvm.global_dtors of the 2-field form in textual format

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 7 21:46:02 PDT 2019


MaskRay marked 3 inline comments as done.
MaskRay added inline comments.


================
Comment at: test/Bitcode/upgrade-global-ctors.ll:7
+
+; ERR: the third field of the element type is mandatory, specify i8* null to migrate from the obsoleted 2-field form
----------------
dexonsmith wrote:
> I don't think this is acceptable when reading from bitcode.
Implemented the autograde code and improved the test a bit.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61547/new/

https://reviews.llvm.org/D61547





More information about the llvm-commits mailing list