[PATCH] D61258: AArch64: support binutils-like things on arm64_32.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 8 07:05:54 PDT 2019


fhahn added inline comments.


================
Comment at: llvm/lib/Support/ARMTargetParser.cpp:292
   // Begins with "arm" / "thumb", move past it.
-  if (A.startswith("arm64"))
+  if (A.startswith("arm64_32"))
+    offset = 8;
----------------
It might be good to add arm64_32 tests to llvm/unittests/Support/TargetParserTest.cpp


================
Comment at: llvm/lib/Support/Triple.cpp:25
   case aarch64_be:     return "aarch64_be";
+  case aarch64_32:     return "aarch64_32";
   case arm:            return "arm";
----------------
It might be good to add arm64_32 tests to llvm/unittests/ADT/TripleTest.cpp


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61258/new/

https://reviews.llvm.org/D61258





More information about the llvm-commits mailing list