[llvm] r360086 - Revert "Re-commit r357452: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)"

[Hans Wennborg via llvm-commits]

FWIW we noticed a ~32 KB size regression on Chrome for Android when
rolling past your revert. Did you make any progress on figuring out
what's wrong with the lowering?

On Tue, May 7, 2019 at 9:12 AM Hans Wennborg <hans at chromium.org> wrote:
>
> Sorry for the breakage.
>
> Please let me know when you have any details about how this broke things.
>
> On Mon, May 6, 2019 at 11:52 PM Jordan Rupprecht via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> >
> > Author: rupprecht
> > Date: Mon May  6 14:55:05 2019
> > New Revision: 360086
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=360086&view=rev
> > Log:
> > Revert "Re-commit r357452: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)"
> >
> > This reverts r357452 (git commit 21eb771dcb5c11d7500fa6ad551c97a921997f05).
> >
> > This was causing strange optimization-related test failures on an internal test. Will followup with more details offline.
> >
> > Modified:
> >     llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp
> >     llvm/trunk/test/CodeGen/AArch64/max-jump-table.ll
> >     llvm/trunk/test/CodeGen/AArch64/min-jump-table.ll
> >     llvm/trunk/test/CodeGen/AArch64/win64-jumptable.ll
> >     llvm/trunk/test/CodeGen/ARM/cmpxchg-idioms.ll
> >     llvm/trunk/test/Transforms/SimplifyCFG/sink-common-code.ll