[PATCH] D60385: FileCheck [5/12]: Introduce regular numeric variables
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 8 05:23:12 PDT 2019
probinson added a comment.
In D60385#1494062 <https://reviews.llvm.org/D60385#1494062>, @thopre wrote:
> In D60385#1493635 <https://reviews.llvm.org/D60385#1493635>, @probinson wrote:
>
> > I still can't tell what the functional difference is, in pattern-defines.txt. Everything else looks fine.
>
>
> There is none, pattern-defines + pattern-defines-diagnostics = old defines.txt + some new comments, as per James' comments.
If there's no functional difference, it should be separated into its own NFC patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60385/new/
https://reviews.llvm.org/D60385
More information about the llvm-commits
mailing list