[PATCH] D61599: [Support] Reverted r357058 and r351916, MemoryBlock class now exposes its allocated size instead of requested size.
Machiel van Hooren via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 8 04:23:28 PDT 2019
mvhooren added a comment.
Looking at FileOutputBuffer, I wonder why it is using MemoryBlock/allocateMappedMemory at all. It probably should be using something like a WritableMemoryBuffer instead.
I have not changed this because it is a little beyond the scope of this patch, but it might be worth investigating. Perhaps it does have a requirement somewhere that its memory should be page-aligned, but if so it is not obvious from looking at it.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61599/new/
https://reviews.llvm.org/D61599
More information about the llvm-commits
mailing list