[llvm] r360236 - [SIMode] Fix typo in Status constructor

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Wed May 8 03:24:22 PDT 2019


Author: rksimon
Date: Wed May  8 03:24:22 2019
New Revision: 360236

URL: http://llvm.org/viewvc/llvm-project?rev=360236&view=rev
Log:
[SIMode] Fix typo in Status constructor

As noted in https://www.viva64.com/en/b/0629/ (Snippet No. 36) and the scan-build CI reports (https://llvm.org/reports/scan-build/report-SIModeRegister.cpp-Status-1-1.html#EndPath), rL348754 introduced a typo in the Status constructor due to argument variable names shadowing the member variable names.

Differential Revision: https://reviews.llvm.org/D61595

Modified:
    llvm/trunk/lib/Target/AMDGPU/SIModeRegister.cpp

Modified: llvm/trunk/lib/Target/AMDGPU/SIModeRegister.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/SIModeRegister.cpp?rev=360236&r1=360235&r2=360236&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AMDGPU/SIModeRegister.cpp (original)
+++ llvm/trunk/lib/Target/AMDGPU/SIModeRegister.cpp Wed May  8 03:24:22 2019
@@ -44,7 +44,7 @@ struct Status {
 
   Status() : Mask(0), Mode(0){};
 
-  Status(unsigned Mask, unsigned Mode) : Mask(Mask), Mode(Mode) {
+  Status(unsigned NewMask, unsigned NewMode) : Mask(NewMask), Mode(NewMode) {
     Mode &= Mask;
   };
 




More information about the llvm-commits mailing list