[PATCH] D55232: [SCEV] Suppress hoisting insertion point of binops when unsafe
Sanjoy Das via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 7 20:00:24 PDT 2019
sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: llvm/lib/Analysis/ScalarEvolutionExpander.cpp:833
} else {
- Prod = InsertBinop(Instruction::Mul, Prod, W);
+ Prod = InsertBinop(Instruction::Mul, Prod, W, true);
}
----------------
Can you please add `/*IsSafeToHoist*/` on these arguments?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55232/new/
https://reviews.llvm.org/D55232
More information about the llvm-commits
mailing list