[PATCH] D61613: [LLD][ELF] Add the -z ifunc-noplt option

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/gnu-ifunc-noplt.s:38
+// DISASM-NEXT:   201026:       ff 25 e4 1f 00 00       jmpq    *8164(%rip)
+// DISASM-NEXT:   20102c:       0f 1f 40 00     nopl    (%rax)
+// DISASM-EMPTY:
----------------
markj wrote:
> MaskRay wrote:
> > You FreeBSD llvm-objdump is old XD
> > 
> > The misindentation made me unhappy so I fixed it in rL358405.
> Not too old :)
> 
> ```
> > llvm-objdump --version
> LLVM (http://llvm.org/):
>   LLVM version 8.0.0
> ```
My change will be included by llvm 9.0.0 ;-) Since you've cloned the monorepo, you may run `ninja -C your/build llvm-objdump` and use that llvm-objdump to update the tests.

I still suggest fixing the misaligned instructions before you commit...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61613/new/

https://reviews.llvm.org/D61613