[PATCH] D50167: RFC: [SCEV] Add explicit representations of umin/smin

[Michael Kruse via llvm-commits]

Polly's SCEVAffinator and SCEVValidator implement the SCEVVisitor
pattern. Consquently, visitor methods for umin/umin need to be
implemented.

Michael

Am Di., 7. Mai 2019 um 16:53 Uhr schrieb Reid Kleckner via Phabricator
via llvm-commits <llvm-commits at lists.llvm.org>:
>
> rnk added a comment.
>
> This broke the polly build:
>
>   [14 processes, 32/64 @ 9.3/s : 3.428s ] Building CXX object tools/polly/lib/CMakeFiles/PollyCore.dir/Support/SCEVAffinator.cpp.o
>   FAILED: tools/polly/lib/CMakeFiles/PollyCore.dir/Support/SCEVAffinator.cpp.o
>   ...
>   In file included from /usr/local/google/home/rnk/llvm-project/polly/lib/Support/SCEVAffinator.cpp:13:
>   In file included from /usr/local/google/home/rnk/llvm-project/polly/include/polly/Support/SCEVAffinator.h:16:
>   /usr/local/google/home/rnk/llvm-project/llvm/include/llvm/Analysis/ScalarEvolutionExpressions.h:536:30: error: no member named 'visitSMinExpr' in 'polly::SCEVAffinator'
>           return ((SC *)this)->visitSMinExpr((const SCEVSMinExpr *)S);
>                  ~~~~~~~~~~~~  ^
>   /usr/local/google/home/rnk/llvm-project/polly/lib/Support/SCEVAffinator.cpp:218:48: note: in instantiation of member function 'llvm::SCEVVisitor<polly::SCEVAffinator, std::pair<isl::noexceptions::pw_aff, isl::noexceptions::set> >::visit' requested here
>       PWAC = SCEVVisitor<SCEVAffinator, PWACtx>::visit(Expr);
>                                                  ^
>   In file included from /usr/local/google/home/rnk/llvm-project/polly/lib/Support/SCEVAffinator.cpp:13:
>   In file included from /usr/local/google/home/rnk/llvm-project/polly/include/polly/Support/SCEVAffinator.h:16:
>   /usr/local/google/home/rnk/llvm-project/llvm/include/llvm/Analysis/ScalarEvolutionExpressions.h:538:30: error: no member named 'visitUMinExpr' in 'polly::SCEVAffinator'
>           return ((SC *)this)->visitUMinExpr((const SCEVUMinExpr *)S);
>                  ~~~~~~~~~~~~  ^
>   2 errors generated.
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D50167/new/
>
> https://reviews.llvm.org/D50167
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits