[PATCH] D61089: [Reassociation] Place moved instructions after landing pads

[Eli Friedman via Phabricator via llvm-commits]

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with a minor comment.



================
Comment at: llvm/lib/Transforms/Scalar/Reassociate.cpp:877
+      // It's possible that V is a PHI in a landingpad block, so make
+      // sure we don't move anything before the landingpad.
+      while (InsertPt != BB->end() && (isa<PHINode>(InsertPt) ||
----------------
Maybe adjust this comment a little?  V could also be a PHI in a non-landingpad block.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61089/new/

https://reviews.llvm.org/D61089