[PATCH] D61599: [Support] MemoryBlock objects now expose their allocated size in addition to the requested size.

Machiel van Hooren via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 7 13:20:30 PDT 2019


mvhooren added a comment.

In D61599#1494000 <https://reviews.llvm.org/D61599#1494000>, @lhames wrote:

> > Yes I agree it would be better if the Size member of MemoryBlock just held the allocated size. This would mean that r357058 and r351916 (and perhaps others) should be reverted.
>
> I agree. To (hopefully) catch all call sites I think we will want to revert, but use your suggested "allocatedSize" name for the method. That should allow us to find and fix any call sites that are making bogus assumptions.


Alright I will update and resubmit the patch tomorrow.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61599/new/

https://reviews.llvm.org/D61599





More information about the llvm-commits mailing list