[PATCH] D60593: [GwpAsan] Introduce GWP-ASan.

[Mitch Phillips via Phabricator via llvm-commits]

hctim marked an inline comment as done.
hctim added inline comments.


================
Comment at: compiler-rt/lib/scudo/scudo_allocator.cpp:305
+#ifdef GWP_ASAN_HOOKS
+    if (UNLIKELY(GuardedAlloc.shouldSample())) {
+      if (void *Ptr = GuardedAlloc.allocate(Size))
----------------
hctim wrote:
> morehouse wrote:
> > hctim wrote:
> > > morehouse wrote:
> > > > What does the assembly for this look like on the fast path?
> > > See attached image in description.
> > Could you just post the assembly?  Preferably a before/after of this fastpath change.
> > 
> > The CFG is confusing for me to read.
> [[ https://pastebin.com/RNUyYBkC | before ]], [[ https://pastebin.com/XfyBtDsp | after ]] the changes
@vlad.tsyrklevich 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60593/new/

https://reviews.llvm.org/D60593