[PATCH] D61300: [SCCP] Fix crash when trying to constant-fold terminators multiple times.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 7 09:11:04 PDT 2019


jdoerfert added a comment.

Do we need to "repair" the folded branch or could we also determine earlier that the current block is dead (it will have an unconditional branch to a dead block, right?) and avoid folding?
It might make sense to fold due to the DT update though.



================
Comment at: llvm/lib/Transforms/Scalar/SCCP.cpp:2087
+        auto *BB = I->getParent();
         bool Folded = ConstantFoldTerminator(I->getParent(),
                                              /*DeleteDeadConditions=*/false,
----------------
now `BB`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61300/new/

https://reviews.llvm.org/D61300





More information about the llvm-commits mailing list