[PATCH] D61425: Install import libraries

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 7 04:03:06 PDT 2019


mstorsjo added a comment.

In D61425#1493179 <https://reviews.llvm.org/D61425#1493179>, @jschueller wrote:

> @mstorsjo Yes, if someone could commit this it would be great


Ok, I can commit it tonight/tomorrow.

FWIW, are you also running into the issue that unittests/Passes/TestPlugin fails to link when building in this configuration? (I did see your separate patch about Shlwapi.)

> For MSVC, this will also install the missing .lib files, but I wont test it.

Yes, and installing them there also makes sense, as DLLs without import libs are pretty pointless. But I'll leave some time for @rnk to comment in any case.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61425/new/

https://reviews.llvm.org/D61425





More information about the llvm-commits mailing list