[PATCH] D61613: [LLD][ELF] Add the -z ifunc-noplt option

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/gnu-ifunc-noplt-i386.s:9
+
+// Check that the IRELATIVE relocations are after the JUMP_SLOT in the plt
+// CHECK: Relocations [
----------------
Where is the `IRELATIVE` relocation? And I don't think the ordering matters.


================
Comment at: lld/test/ELF/gnu-ifunc-noplt-i386.s:43
+// DISASM-EMPTY:
+// DISASM-NEXT:   bar2 at plt:
+// DISASM-NEXT:    401030:       ff 25 0c 30 40 00       jmpl    *4206604
----------------
Not sure if you need `bar2 at plt` `zed2 at plt`. The normal PLT entries are checked by numerous tests.


================
Comment at: lld/test/ELF/gnu-ifunc-noplt.s:9
+
+// Check that the IRELATIVE relocations are after the JUMP_SLOT in the plt XXX
+// CHECK: Relocations [
----------------
Same question goes here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61613/new/

https://reviews.llvm.org/D61613