[PATCH] D60353: ELF: Add basic partition data structures and behaviours.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/partitions.s:4
+// RUN: ld.lld %t.o -o %t --export-dynamic --gc-sections
+// RUN: llvm-readobj -sections -symbols -elf-output-style=GNU %t | FileCheck %s
+
----------------
pcc wrote:
> MaskRay wrote:
> > `-symbols` -> `-dyn-syms`?
> > 
> > e.g. `llvm-readelf -S -dyn-syms %t`
> That would not be sufficient to test the property that we're interested in here because `f[3-6]` are not exported.
Then use either `llvm-readobj` or `llvm-readelf`, but not `-elf-output-style=GNU`.

( `llvm-readobj -elf-output-style=GNU` has a peculiarity: it supports `llvm-readobj` specific options but not `llvm-readelf` options. In any case, I've done something to improve their compatibility.) If you decide to go with `llvm-readelf`, `--long-option` will be better than `-long-option` :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60353/new/

https://reviews.llvm.org/D60353