[PATCH] D61563: [ELF] Error on relocations to local undefined symbols

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

I also do not know if undefined local symbol can be a real thing.
So my comment is about implementation.



================
Comment at: ELF/Relocations.cpp:1032
+  // be used by R_*_NONE. Don't error on them.
+  if (SymIndex != 0 && maybeReportUndefined(Sym, Sec, Rel.r_offset))
     return;
----------------
Should we just never report error for R_*_NONE maybe? I.e use `Type == Target->NoneRel` here?
(should look a bit better than comparing symbol index it seems).

Do we have a test for that btw?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61563/new/

https://reviews.llvm.org/D61563