[PATCH] D61613: [LLD][ELF] Add the -z ifunc-noplt option

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Generally looking good.



================
Comment at: lld/ELF/Driver.cpp:891
   Config->ZHazardplt = hasZOption(Args, "hazardplt");
+  Config->ZIfuncnoplt = hasZOption(Args, "ifunc-noplt");
   Config->ZInitfirst = hasZOption(Args, "initfirst");
----------------
According to the convention, this should be ZIfuncNoplt.


================
Comment at: lld/docs/ld.lld.1:552-553
+Instead, emit text relocations referencing the resolver.
+This is an experimental optimization and only suitable for standalone
+environments where text relocations are permitted.
 .It Cm initfirst
----------------
IIRC, text relocations are not preferred but actually permitted in most environment, no? I'd mention that this option is intended to be used for the kernel where an existence of text relocation doesn't matter but the cost of PLT matters.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61613/new/

https://reviews.llvm.org/D61613